Update traject to 3.8.2 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I need to update the Gemfile.lock, which I can't do because I still haven't managed to connect to pkg.github. Can you? |
niquerio
force-pushed
the
traject_3.8.2
branch
from
16ff27a
to
ab04add
Compare
niquerio
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
That did get lost in the shuffle. I've also been meaning to put in a PR to traject regarding ignore_namespace but I haven't gotten to that either. For context the code I'd change is in: lib/marc_reader_fix.rb
I took out the need for the Github PAT since we talked about doing that before. I also did a bit of cleaning while I'm here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you had planned on changing the traject version to the new release that fixes the filing characters bug for items with 880s, but it may have gotten lost in the shuffle.
All this does is change the Gemfile to force traject 3.8.2 or higher.