Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor translation map fetcher #69

Merged
merged 13 commits into from
Feb 29, 2024
Merged

Conversation

niquerio
Copy link
Collaborator

@niquerio niquerio commented Feb 26, 2024

  • Moves Jobs::Utilities::TranslationMapFetcher to Jobs::TranslationMapGenerator
  • Moves Jobs::ElectronicCollections and Jobs::LibLocInfo`` under the namespace Jobs::TranslationMapGenerator`
  • Wraps HighLevelBrowse in a module and makes it act like other TranslationMapGenerator classes
  • Adds Canister for storing the logger and the project_root_path
  • Adds Semantic logger
  • Adds tests for the TranslationMapGenerator

All of this is fairly well tested.

@niquerio niquerio marked this pull request as ready for review February 29, 2024 18:39
@niquerio niquerio merged commit f2a47f9 into main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant