Split up json #70
Closed
Split up json #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets arbitratry files from an sftp server, puts it in a local directory, can delete the local directory later
billdueber
reviewed
Mar 20, 2024
| include Traject::Macros::Marc21Semantics | ||
| def initialize(raw) | ||
| @raw = raw | ||
| @record = MARC::JSONLReader.new(StringIO.new(@raw)).first |
There was a problem hiding this comment.
Can be MARC::Record.new_from_hash(JSON.parse(@raw))
billdueber
reviewed
Mar 20, 2024
| S.logger.info "Writing filtered records from #{full_zephir_file} to the #{scratch_dir} directory" | ||
| Zinzout.zin(full_zephir_file) do |infile| | ||
| # count = 0 | ||
| infile.each.each_slice(batch_size) do |lines| |
There was a problem hiding this comment.
Can just use each_slice
billdueber
reviewed
Mar 20, 2024
|
|
||
| @line_count = 0 | ||
| @file_count = 0 | ||
| _update_current_file_path |
There was a problem hiding this comment.
Turn these into functions that take what they need and return a string, so you end up with
@current_file_path = _update_current_file_path(blah blah gblah)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.