Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

January 2024 dependency updates. #40

Merged
merged 3 commits into from
Jan 25, 2024
Merged

January 2024 dependency updates. #40

merged 3 commits into from
Jan 25, 2024

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Jan 8, 2024

Overview

Monthly dependency update to help maintain Get This.

NPM

These dependencies have been updated to their latest versions:

  • cssnano
  • postcss
  • postcss-cli
  • postcss-import

Bundler

Notable update is adding rackup to the gem file. It got removed from the rack gem at the 3.0 update. rack-sessions did too, but it's included in Sinatra.

GITHUB_TOKEN

Changes Dockerfile to use github_token instead of gh_package_read_token which is deprecated.

Testing

  • Install the updated packages (docker-compose run --rm web npm install).
  • Make a CSS change, and build the styles (docker-compose run --rm web npm run build).
  • Start the site to see if your change was made, and everything still works (docker-compose up).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge

@erinesullivan erinesullivan added the dependencies Changes to packages or gems. label Jan 8, 2024
@erinesullivan erinesullivan self-assigned this Jan 8, 2024
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some fixes to change GH_PACKAGE_READ_TOKEN to GITHUB_TOKEN. Now it appears to be working properly. 🚢

@niquerio niquerio merged commit da84f1d into main Jan 25, 2024
3 of 4 checks passed
@erinesullivan erinesullivan deleted the 2024-01-08-updates branch February 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to packages or gems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants