Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native AddIncludeFile method #18

Merged
merged 15 commits into from
Jan 7, 2025

Conversation

raviqqe
Copy link
Member

@raviqqe raviqqe commented Jan 6, 2025

This PR changes the add_source_file method in Rust to use AddIncludeFile in C++ which resolves given file paths from include directories.

This PR depends on #19.

References

@raviqqe raviqqe enabled auto-merge (squash) January 6, 2025 12:00
@raviqqe raviqqe marked this pull request as draft January 6, 2025 12:03
auto-merge was automatically disabled January 6, 2025 12:03

Pull request was converted to draft

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@raviqqe raviqqe closed this Jan 6, 2025
This reverts commit 6d00535.
This reverts commit 2044c7b.
@raviqqe raviqqe reopened this Jan 6, 2025
This reverts commit f5b2560.
@raviqqe raviqqe force-pushed the feature/include-file branch 2 times, most recently from 47eb794 to 46ac7f0 Compare January 7, 2025 10:42
@raviqqe raviqqe marked this pull request as ready for review January 7, 2025 11:11
@raviqqe raviqqe enabled auto-merge January 7, 2025 11:13
@raviqqe raviqqe disabled auto-merge January 7, 2025 11:13
@raviqqe raviqqe enabled auto-merge (squash) January 7, 2025 11:14
@raviqqe raviqqe requested a review from edg-l January 7, 2025 11:16
@raviqqe raviqqe merged commit 6495e35 into mlir-rs:master Jan 7, 2025
7 checks passed
raviqqe added a commit to mlir-rs/melior that referenced this pull request Jan 16, 2025
This PR refactors dialect macro input.

# References

- Depends on mlir-rs/tblgen-rs#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants