Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unclosed files (#751, #755, #756, #757) #765

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

a-szulc
Copy link
Contributor

@a-szulc a-szulc commented Aug 29, 2024

changed all examples of

params = json.load(open(os.path.join(path, "params.json")))

and similar,

to

with open(os.path.join(path, "params.json")) as file:
    params = json.load(file)

@pplonski pplonski merged commit c3f9ac8 into mljar:master Aug 29, 2024
1 check passed
@pplonski
Copy link
Contributor

Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants