Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change X.iloc[:, 1] to X[column_name] so there is no warning from pandas (fixes #750) #772

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

a-szulc
Copy link
Contributor

@a-szulc a-szulc commented Sep 2, 2024

changed

X.iloc[:, i] = X.iloc[:, i].astype(str)

if X_validation is not None:
  X_validation.iloc[:, i] = X_validation.iloc[:, i].astype(str)

to

col_name = X.columns[i]
X[col_name] = X[col_name].astype(str)

if X_validation is not None:
    X_validation[col_name] = X_validation[col_name].astype(str)

this prevents Future warning from pandas of setting incompatible dtype

@pplonski pplonski merged commit bef7984 into mljar:master Sep 2, 2024
1 check passed
@pplonski
Copy link
Contributor

pplonski commented Sep 2, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants