Extract Link type for unsafe rotations
#26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## This Commit Extracts a `Link` type to implement on rotations so root and non-root nodes can rotate purely through pointer swapping. ## Why? This method of rotation is simpler to understand and maintain compared to the previous `mem::swap` approach. Also, for nodes with large keys/values, moving pointers will be faster than `mem::swap`ping node fields. ## Benchmarks With the change of benchmarks to have nodes with `[i32; 1024]`, it seems to make an improvement but it didn't help for nodes with `i32` values. We might want a constant time check to decide between the two based on the types of `K` and `V`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Commit
Extracts a
Linktype to implement on rotations so root and non-root nodes can rotate purely through pointer swapping.Why?
This method of rotation is simpler to understand and maintain compared to the previous
mem::swapapproach. Also, for nodes with large keys/values, moving pointers will be faster thanmem::swapping node fields.Benchmarks
With the change of benchmarks to have nodes with
[i32; 1024], it seems to make an improvement but it didn't help for nodes withi32values. We might want a constant time check to decide between the two based on the types ofKandV.