update to C++14 standard #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradsnicta
added
c: optimizers
c: documentation
c: build system
and removed
s: unlabeled
labels
zoq
approved these changes
Jun 8, 2024
shrit
approved these changes
Jun 8, 2024
coatless
approved these changes
Jun 8, 2024
|
Awesome, I actually did not know about |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update C++ standard to C++14.
mlpack 4.4 already requires C++17, and Armadillo 14.0 will use C++14.
The only OS that required C++11 is RHEL 7 / CentOS 7, which is EOL as of 30 June 2024:
Using "two most recent releases of long term Linux distros" as the yardstick for compiler support. The Linux distros are: RHEL (+ clones like Rocky Linux and Alma Linux), Ubuntu LTS, and Debian.
The current two supported releases of RHEL (8 and 9), Ubuntu LTS (22.04 and 24.04), Debian (11 and 12) all provide GCC versions that support at least C++14.
RHEL 8 does not support C++17 properly, so not bumping the C++ standard to C++17.