Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace german_credit data with corrected data from rchallenge package #514

Merged
merged 3 commits into from
Jul 20, 2020

Conversation

sumny
Copy link
Member

@sumny sumny commented Jun 25, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files          80       80           
  Lines        2027     2027           
=======================================
  Hits         1880     1880           
  Misses        147      147           
Impacted Files Coverage Δ
R/TaskClassif_german_credit.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3867f58...3ea4670. Read the comment docs.

Copy link
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will this affect posts in mlr3gallery?

@sumny
Copy link
Member Author

sumny commented Jun 25, 2020

Thanks! Will this affect posts in mlr3gallery?

In principle, this affects:

  • 2020-03-11-basics-german-credit (runs fine because no specific use of the internal structure of variables is made here)

  • 2020-03-11-mlr3pipelines-tutorial-german-credit (should run fine but is no longer very sensible because now there are only 3 integer features being used and the filter is using 3 features, therefore needs some minor changes)

  • 2020-03-11-mlr3tuning-tutorial-german-credit (runs fine but uses data from here https://github.com/mlr-org/mlr-outreach/raw/master/2019_madrid/mlr3tuning/randomsearch_3600.rds which uses the old german_credit; not sure whether other outreach files need to be changed/looked at as well)

  • 2020-03-30-stratification-blocking (runs fine, no changes needed)

  • 2020-01-31-encode-factors-for-xgboost (needs minor wording changes because there is now more than one ordered factor and unemployment_duration is now a factor)

I could open an issue in mlr3gallery and fix the posts above?

@pat-s
Copy link
Member

pat-s commented Jun 25, 2020

I could open an issue in mlr3gallery and fix the posts above?

Yes, please.

Thanks!

@mllg
Copy link
Member

mllg commented Jul 6, 2020

Thanks. I'll merge as soon as there are fixes for the gallery.

@mllg
Copy link
Member

mllg commented Jul 20, 2020

Thanks, will merge now, upload, and repair the gallery posts.

@mllg mllg merged commit eb483dc into master Jul 20, 2020
@mllg mllg deleted the german_credit_fix branch July 20, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants