Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log internal tuned values #489

Merged
merged 8 commits into from
Feb 10, 2025
Merged

feat: log internal tuned values #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b095a7
feat: log internal tuned values
be-marc Jan 31, 2025
8656083
...
be-marc Feb 10, 2025
351e091
Merge branch 'main' into print_internal
be-marc Feb 10, 2025
a96fc0a
...
be-marc Feb 10, 2025
9c40ce1
...
be-marc Feb 10, 2025
0c4f22d
...
be-marc Feb 10, 2025
7b801b0
...gp
be-marc Feb 10, 2025
5b3f965
...
be-marc Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ S3method(extract_inner_tuning_archives,BenchmarkResult)
S3method(extract_inner_tuning_archives,ResampleResult)
S3method(extract_inner_tuning_results,BenchmarkResult)
S3method(extract_inner_tuning_results,ResampleResult)
S3method(format_list_item,internal_tuned_values)
S3method(marshal_model,auto_tuner_model)
S3method(set_validate,AutoTuner)
S3method(unmarshal_model,auto_tuner_model_marshaled)
Expand Down
7 changes: 6 additions & 1 deletion R/helper.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extract_runtime = function(resample_result) {

extract_inner_tuned_values = function(resample_result, internal_search_space) {
internal_tuned_values = transpose_list(map(get_private(resample_result)$.data$learner_states(get_private(resample_result)$.view), "internal_tuned_values"))
internal_search_space$aggr_internal_tuned_values(internal_tuned_values)
set_class(internal_search_space$aggr_internal_tuned_values(internal_tuned_values), "internal_tuned_values")
}


Expand All @@ -38,3 +38,8 @@ split_internal_search_space = function(search_space) {
}
list(search_space = search_space, internal_search_space = NULL)
}

#' @export
format_list_item.internal_tuned_values = function(x, ...) {
as_short_string(unclass(x))
}
4 changes: 2 additions & 2 deletions tests/testthat/test_ArchiveAsyncTuning.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ test_that("Saving ArchiveAsyncTuning works", {
loaded_instance = readRDS(file = "instance.rds")

loaded_instance$reconnect()
loaded_instance
expect_class(loaded_instance, "TuningInstanceAsyncSingleCrit")
})

# Internal Tuning --------------------------------------------------------------
Expand All @@ -277,7 +277,7 @@ test_that("ArchiveAsyncTuning as.data.table function works internally tuned valu

tab = as.data.table(instance$archive, unnest = "x_domain")
expect_list(tab$internal_tuned_values, min.len = 2, types = "list")
expect_equal(tab$internal_tuned_values[[1]], list(iter = 99L))
expect_equal(tab$internal_tuned_values[[1]], set_class(list(iter = 99L), "internal_tuned_values"))

tab = as.data.table(instance$archive)
expect_names(names(tab), must.include = "internal_tuned_values_iter")
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test_ArchiveBatchTuning.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ test_that("ArchiveBatchTuning as.data.table function works for internally tuned

tab = as.data.table(instance$archive, unnest = "x_domain")
expect_list(tab$internal_tuned_values, min.len = 2, types = "list")
expect_equal(tab$internal_tuned_values[[1]], list(iter = 99L))
expect_equal(tab$internal_tuned_values[[1]], set_class(list(iter = 99L), "internal_tuned_values"))

tab = as.data.table(instance$archive)
expect_names(names(tab), must.include = "internal_tuned_values_iter")
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test_Tuner.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ test_that("internal single crit", {
term_evals = 4
)
expect_equal(
ti$archive$data$internal_tuned_values, replicate(list(list(iter = 99L)), n = 4L)
ti$archive$data$internal_tuned_values, replicate(list(set_class(list(iter = 99L), "internal_tuned_values")), n = 4L)
)
expect_equal(
ti$result_learner_param_vals$iter, 99L
Expand All @@ -211,7 +211,7 @@ test_that("internal single crit without benchmark_result", {
store_benchmark_result = FALSE
)
expect_equal(
ti$archive$data$internal_tuned_values, replicate(list(list(iter = 99L)), n = 4L)
ti$archive$data$internal_tuned_values, replicate(list(set_class(list(iter = 99L), "internal_tuned_values")), n = 4L)
)
expect_equal(
ti$result_learner_param_vals$iter, 99L
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test_TuningInstanceAsyncSingleCrit.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ test_that("Async single-crit internal tuning works", {
expect_data_table(tuner$optimize(instance), nrows = 1)

expect_list(instance$archive$finished_data$internal_tuned_values, min.len = 20, types = "list")
expect_equal(instance$archive$finished_data$internal_tuned_values[[1]], list(iter = 99))
expect_equal(instance$archive$finished_data$internal_tuned_values[[1]], set_class(list(iter = 99L), "internal_tuned_values"))
expect_false(instance$result_learner_param_vals$early_stopping)
expect_equal(instance$result_learner_param_vals$iter, 99)
expect_rush_reset(instance$rush, type = "kill")
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test_TuningInstanceBatchMultiCrit.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ test_that("Batch multi-crit internal tuning works", {
tuner = tnr("random_search", batch_size = 2)
expect_data_table(tuner$optimize(instance), min.rows = 1)
expect_list(instance$archive$data$internal_tuned_values, len = 20, types = "list")
expect_equal(instance$archive$data$internal_tuned_values[[1]], list(iter = 99))
expect_equal(instance$archive$data$internal_tuned_values[[1]], set_class(list(iter = 99L), "internal_tuned_values"))
expect_false(instance$result_learner_param_vals[[1]]$early_stopping)
expect_equal(instance$result_learner_param_vals[[1]]$iter, 99)
})
2 changes: 1 addition & 1 deletion tests/testthat/test_TuningInstanceBatchSingleCrit.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ test_that("Batch single-crit internal tuning works", {
tuner = tnr("random_search", batch_size = 2)
expect_data_table(tuner$optimize(instance), nrows = 1)
expect_list(instance$archive$data$internal_tuned_values, len = 20, types = "list")
expect_equal(instance$archive$data$internal_tuned_values[[1]], list(iter = 99))
expect_equal(instance$archive$data$internal_tuned_values[[1]], set_class(list(iter = 99L), "internal_tuned_values"))
expect_false(instance$result_learner_param_vals$early_stopping)
expect_equal(instance$result_learner_param_vals$iter, 99)
})
Expand Down