Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minio] change Minio parameters to secret in workflows. #90

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

tomerm-iguazio
Copy link

@tomerm-iguazio tomerm-iguazio commented Mar 5, 2024

Minio parameters should save as secrets in yaml files...

S3_ENDPOINT_URL
AWS_SECRET_ACCESS_KEY
AWS_ACCESS_KEY_ID

@tomerm-iguazio tomerm-iguazio marked this pull request as ready for review March 5, 2024 13:31
@tomerm-iguazio tomerm-iguazio marked this pull request as draft March 5, 2024 13:32
Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! A couple minor things

charts/mlrun-ce/values.yaml Outdated Show resolved Hide resolved
charts/mlrun-ce/templates/config/minio-env-secret.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants