Patch: introduce proper plural form strings and fix typo #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“othographic” → “orthographic”
Currently, the source code on subtitles either assumes subtitle items to be always in plural form or tries determines plural form by itself. This commit fixes that by using builtin `QObject::tr` plural support.
rschiang
changed the title
“shne” → “shine”
|
Thank you, but this must wait until after the next release because we are late in beta when we do not change strings that can break existing translations (not enough time for translators to update). |
“Seperate” → “Separate”
|
Thank you for the swift reply! Waiting until the next release cycle seems fair. Please merge them whenever you feel right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch consolidates some source string issues found during the translation process.
ortographic→orthographic, as in orthographic projectionseperate→separateQObject::trcalls with proper plural form support (with thenparameter)Hope this helps! 🚀