Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoplot missing name error (and previous warning) #113

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

cregouby
Copy link
Collaborator

@cregouby cregouby commented Feb 5, 2023

@cregouby cregouby requested a review from dfalbel February 5, 2023 09:49
Copy link
Member

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #113 (857ed13) into main (5f5a702) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   87.45%   87.39%   -0.06%     
==========================================
  Files          10       10              
  Lines        1060     1063       +3     
==========================================
+ Hits          927      929       +2     
- Misses        133      134       +1     
Impacted Files Coverage Δ
R/model.R 94.59% <100.00%> (ø)
R/pretraining.R 94.30% <100.00%> (ø)
R/package.R 0.00% <0.00%> (ø)
R/parsnip.R 99.08% <0.00%> (+<0.01%) ⬆️
R/explain.R 92.50% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cregouby cregouby merged commit 44c35eb into main Feb 6, 2023
@cregouby cregouby deleted the bugfix/autoplot_warning branch February 6, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoplot(model_fit) fails with Can't unnest elements with missing names.
2 participants