Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stopifnot to prevent missing values #24

Merged
merged 5 commits into from
Jan 19, 2021
Merged

add stopifnot to prevent missing values #24

merged 5 commits into from
Jan 19, 2021

Conversation

cregouby
Copy link
Collaborator

fix #23

@cregouby cregouby changed the title add stopifnot in case of missing values add stopifnot to prevent missing values Jan 18, 2021
@dfalbel
Copy link
Member

dfalbel commented Jan 18, 2021

Thanks @cregouby !

IMHO we shouldn't fail in predict if only the response variable has missing values. What do you think?

@cregouby
Copy link
Collaborator Author

I fully agree. I made a typo quoting NA in expect_error. Thanks for the review, sorry for this.

@dfalbel
Copy link
Member

dfalbel commented Jan 19, 2021

Thanks very much!!

@dfalbel dfalbel merged commit 29dfed5 into mlverse:main Jan 19, 2021
@cregouby cregouby deleted the feature/missing_values branch January 23, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime_error("Indices/Index start at 1 and got a 0.") when missing values in the dataset is misleading
3 participants
@cregouby @dfalbel @Christophe-Regouby