Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/#35 other losses #55

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Bugfix/#35 other losses #55

merged 6 commits into from
Jun 22, 2021
+96 −32

Conversation

cregouby
Copy link
Collaborator

A fix to #35 :

  • allow loss to be functions
  • enforce explicit loss to match outcome dtype

cregouby added 5 commits June 20, 2021 13:00
@cregouby
add more tests around config$loss
de3d54d 
shift left the config$loss_fn resolution
@cregouby
move resolve_loss as a cunction
a8b1c8a 
add consistency check between loss and outcome dtype
allow loss as function
@cregouby
get rid of enumerate(dl)
d289ca0
@cregouby
fix the test to loss "auto" to not interfeare with function()
f3f2f77 
adapt the tests expectations
@cregouby
add loss as a function PR
0dcb563
@cregouby cregouby mentioned this pull request Jun 20, 2021
Closed
20 tasks
@cregouby cregouby requested a review from dfalbel June 21, 2021 19:23
@dfalbel dfalbel merged commit 2d93f60 into main Jun 22, 2021
@dfalbel
Copy link
Member

dfalbel commented Jun 22, 2021

Thanks very much!!

@cregouby cregouby deleted the bugfix/#35_other_losses branch October 23, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfalbel dfalbel dfalbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cregouby @dfalbel