Skip to content

Commit

Permalink
Implemented compatibility with color mode support in the latest Home …
Browse files Browse the repository at this point in the history
…Assistant + ESPHome. (#44)

Co-authored-by: Maurice Makaay <mmakaay1@xs4all.net>
  • Loading branch information
mmakaay and Maurice Makaay authored Aug 5, 2021
1 parent 7de641f commit 3868b86
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 8 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.2.0-RC1]

**Note**: This release requires ESPHome v1.21.0 and Home Assistant 2021.8.0 or newer.

### Changed
- The code has been made compatible with the new color mode support in Home Assistant.

## [1.1.0]

**Note**: This release requires ESPHome v1.20.0 or newer.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ aspect of the lamp and to integrate the lamp in your Home Assistant setup.

For those who have experience with flashing ESPHome onto devices:

* Make sure you are using ESPHome v1.20.0 or newer.
* Make sure you are using ESPHome v1.21.0 or newer.
* Copy [`example.yaml`](example.yaml) to `<CONFIG_DIR>/<NODE_NAME>.yaml`.
* Modify the configuration to your needs (see the [configuration guide](doc/configuration.md)).
* Compile the `firmware.bin` file and download it to the device to which you have connected your
Expand Down
2 changes: 1 addition & 1 deletion components/xiaomi_bslamp2/light/color_rgb_light.h
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class ColorRGBLight : public GPIOOutputs {
bool set_light_color_values(light::LightColorValues v) {
light_mode = LIGHT_MODE_RGB;

if (v.get_white() > 0.0f) {
if (v.get_color_mode() != light::ColorMode::RGB) {
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion components/xiaomi_bslamp2/light/color_white_light.h
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class ColorWhiteLight : public GPIOOutputs {
bool set_light_color_values(light::LightColorValues v) {
light_mode = LIGHT_MODE_WHITE;

if (v.get_white() == 0.0f) {
if (v.get_color_mode() != light::ColorMode::COLOR_TEMPERATURE) {
return false;
}

Expand Down
6 changes: 1 addition & 5 deletions components/xiaomi_bslamp2/light/light_output.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@ class XiaomiBslamp2LightOutput : public Component, public light::LightOutput {
*/
light::LightTraits get_traits() override {
auto traits = light::LightTraits();
traits.set_supports_rgb(true);
traits.set_supports_color_temperature(true);
traits.set_supports_brightness(true);
traits.set_supports_rgb_white_value(false);
traits.set_supports_color_interlock(true);
traits.set_supported_color_modes({light::ColorMode::RGB, light::ColorMode::COLOR_TEMPERATURE});
traits.set_min_mireds(MIRED_MIN);
traits.set_max_mireds(MIRED_MAX);
return traits;
Expand Down

0 comments on commit 3868b86

Please sign in to comment.