Add async support via Tokio #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! |
|
On it! |
|
Done. |
|
There’s quite a bit of code duplication between the sync and async reader implementations: there might be something we can do with macros. I'll try to think about it on my own, but maybe we can take inspiration from other crates like |
|
Hello, what was decided regarding this? I'd like to know. Thanks! |
|
Hi, I closed the PR by deleting the dev branch, I've just restored it. |
|
Do let me know if I can help with something after you've thought about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your great work on this crate!
This PR adds support for readers that implement Tokio's
AsyncReadandAsyncSeektraits.My use case is determining the file format of potentially large S3 objects without having to read entire objects into memory first. A reader that implements
AsyncReadis provided courtesy of aws_smithy_types, but forAsyncSeekI had to implement my own wrapper on top. An example of such can be provided if needed.Adding async support required moving common functionality away from the file format readers first, then introducing async implementations of those readers in parallel with the sync versions. The commit sequence shows this step-by-step.
Please let me know if there are any changes required.