Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to syn 2.0 #262

Merged
merged 1 commit into from
Mar 26, 2023
Merged

chore: Upgrade to syn 2.0 #262

merged 1 commit into from
Mar 26, 2023

Conversation

audunhalland
Copy link
Contributor

No description provided.

@mmastrac mmastrac merged commit a93fd67 into mmastrac:master Mar 26, 2023
@mmastrac
Copy link
Owner

Thank you, I'll push a new version with a minor bump.

jdx referenced this pull request Mar 27, 2023
@Kixunil
Copy link

Kixunil commented Oct 25, 2023

Hey, from my understanding, this didn't change the API so bumping minor version wasn't really needed. Not a big deal I guess just something to be aware of in the future. Cool crate, BTW!

@mmastrac
Copy link
Owner

Technically true from a strict semver read, but it makes it slightly easier for people to select which version they want based on the minor since it's still a 0.x project as some folks prefer not to have two major version lines of syn in their trees.

@Kixunil
Copy link

Kixunil commented Oct 25, 2023

That's still possible using Cargo.lock and that's what should be used (and I use it). Doing it via Cargo.toml makes the experience strictly worse because e.g. some other crate might forget to use ranged version and then it forces specific version on people.

@mmastrac
Copy link
Owner

In this case it doesn't hurt anything to also bump the minor because it's still 0.x, but thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants