Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering depth is broken for non-perspective cameras #254

Open
TimSchneider42 opened this issue Apr 14, 2023 · 0 comments
Open

Rendering depth is broken for non-perspective cameras #254

TimSchneider42 opened this issue Apr 14, 2023 · 0 comments

Comments

@TimSchneider42
Copy link

Hi,

When computing the depth, the renderer seems to always assume that the camera is a perspective camera (see Renderer.read_depth_buf). If we use a different camera, like an orthographic camera, the depth is no longer computed correctly.

The solution is to take the type of camera into account when computing the depth. Somebody already did this in a pull request in 2019, but it never got merged (see #40). Is there a reason for that? I currently have to resort to undoing the wrong computation manually and then applying the correct formula as a workaround to get the depth, which is quite an ugly hack.

Best,
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant