Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed recovery of metric depth for orthographic cameras #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andreanicastro
Copy link

Following the dissection of the opengl camera matrix I fixed what I think is a bug in the recovery of the metric depth for orthographic cameras.
Please let me know if there are any changes or test you would like to be added to the PR.

@kampelmuehler
Copy link

This indeed fixes the issues with incorrect depth values when using orthographic cameras.

@lizelive
Copy link

lizelive commented Nov 8, 2023

this fixes orthographic depth bug @mmatl i see you have branch https://github.com/mmatl/pyrender/commits/depth_linearization

maxbarnikol added a commit to maxbarnikol/pyrender that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants