Fix Problem with M1 Macs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmazzarolo
requested changes
Nov 17, 2021
packages/mobile/package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "scripts": { | |||
| "android": "react-native run-android", | |||
| "ios": "react-native run-ios", | |||
| "ipad": "react-native run-ios --simulator='iPad Air (4th generation)'", | |||
There was a problem hiding this comment.
Can we avoid adding this script? You can run it anyway passing the simulator options to yarn ios 👍
package.json
Outdated
| @@ -25,6 +25,7 @@ | |||
| "android:studio": "yarn workspace @my-app/mobile studio", | |||
| "ios:metro": "yarn workspace @my-app/mobile start", | |||
| "ios:start": "yarn workspace @my-app/mobile ios", | |||
| "ipad:start": "yarn workspace @my-app/mobile ipad", | |||
There was a problem hiding this comment.
Can we avoid adding this script? You can run it anyway passing the simulator options to yarn ios 👍
There was a problem hiding this comment.
sorry about that one, I was using it on my project but somehow I made a pull request for that change, I submitted a new commit without it
This reverts commit e6cc3cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Apple Silicon to work at all you need to address a linker problem with react-native and Swift libraries
Fix as described in:
facebookarchive/react-native-fbsdk#755