-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infernal output could align to the negative strand #27
Conversation
This makes sure we don't get empty values here: https://github.com/barricklab/pLannotate/blob/daabf1a63be79c43ff6166c76403d358b1d53da8/plannotate/annotate.py#L385
@nh13 Some questions about this PR...
Please advise! |
My apologies, I should have included the test case from the start command
test.fasta
debug.yaml: Rfam:
details:
compressed: false
default_type: ncRNA
location: None
location: Default
method: infernal
priority: 3
version: release 14.5 |
The reason this fails is because |
I added one more commit, where the original commits failed on this read:
Weirdly, after swapping the columns, pandas changes the types of the qstart and qend columns from an integer to a float! |
This works now in my testing, including on the case where it caused a crash before, so I'm merging this. I am leaving a note here that I don't understand the further processing of |
This makes sure we don't get empty values here: https://github.com/barricklab/pLannotate/blob/daabf1a63be79c43ff6166c76403d358b1d53da8/plannotate/annotate.py#L385