Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/thirdparty: add standard library crypto/ed25519 #226

Closed
mmcloughlin opened this issue Nov 8, 2021 · 1 comment
Closed

tests/thirdparty: add standard library crypto/ed25519 #226

mmcloughlin opened this issue Nov 8, 2021 · 1 comment
Labels
testing Tests and supporting infrastructure

Comments

@mmcloughlin
Copy link
Owner

mmcloughlin commented Nov 8, 2021

Add the standard library crypto/ed25519 package to the third-party test suite.

This is clearly going to be a bit of an edge case as the first attempt #225 shows.

  • Building the target Go version with make.bash is slow
  • Can we run the tests vs the installed Go version, not the checked out Go version?
  • Can we install from a release version, directly or with golang.org/x/dl?
  • If we install a release version, how would we handle the case where we test with the -latest flag.
  • Can we make use of caching in github actions?
@mmcloughlin mmcloughlin added the testing Tests and supporting infrastructure label Nov 8, 2021
@mmcloughlin
Copy link
Owner Author

While I figure out what to do about the standard library test case, I've added #227 to test the package it's vendored from.

cc @FiloSottile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests and supporting infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant