Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: contributor PRs fail the pr/automerge step #381

Closed
mmcloughlin opened this issue Mar 6, 2023 · 1 comment · Fixed by #382
Closed

ci: contributor PRs fail the pr/automerge step #381

mmcloughlin opened this issue Mar 6, 2023 · 1 comment · Fixed by #382

Comments

@mmcloughlin
Copy link
Owner

Since the changes to support auto-landed commits, PRs from forks fail the automerge step. See #372 for example.

This makes contributor PRs unlandable, which we should fix.
@mmcloughlin
Copy link
Owner Author

Jobs fail to get an app token, which makes sense:

Error: Error: Input required and not supplied: app_id

https://github.com/mmcloughlin/avo/actions/runs/4226443316/jobs/7339884468#step:2:6

I think the entire job should be skipped if the actor is not the bot user, not just the automerge step.

@mmcloughlin mmcloughlin mentioned this issue Mar 6, 2023
Merged
mmcloughlin added a commit that referenced this issue Mar 6, 2023
@mmcloughlin
ci: skip entire autoland job for non-bot users
40deebf 
Fixes #381
mmcloughlin added a commit that referenced this issue Mar 6, 2023
@mmcloughlin
ci: skip entire autoland job for non-bot users (#382)
5935b03 
In contributor PRs such as #372 we see that the pr/autoland job fails
due to permissions issues obtaining an app token from a fork.

This job is actually only required to auto-land bot PRs. Instead of
skipping just the auto-land setting step, we should be skipping the
entire thing.

Fixes #381
@mmcloughlin mmcloughlin mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: skip entire autoland job for non-bot users mmcloughlin/avo
1 participant
@mmcloughlin