Update make_const.go floating point format verb #388
Conversation
Change floating point format verb to `%#f` from `%#v` to ensure floating point constants are always printed with a decimal, ensuring they will be correctly interpreted by the Go assembler. Closes mmcloughlin#387.
|
@dmgard Thanks for the PR! I expect you'll need to rerun code generation for this to work. Should be enough to run |
|
It would also be good to add a regression test for this, see the tests under: https://github.com/mmcloughlin/avo/tree/master/tests/fixedbugs I could also follow-up with this myself. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 99 99
Lines 23728 23728
=======================================
Hits 18537 18537
Misses 5095 5095
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@mmcloughlin thanks for avo! This skipped my mind soon after I submitted it. Haven't had the time to follow-up and, at this rate, you'd probably get to it first. |
|
@mmcloughlin great, works like a charm, thanks. |
Change floating point format verb to
%#ffrom%#vto ensure floating point constants are always printed with a decimal, ensuring they will be correctly interpreted by the Go assembler. Closes #387.