Add primary_currency to user object #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Code looks good initially, but let me figure out why the unit tests aren't running on your PR 👀 |
mmenanno
force-pushed
the
add-primary-currency-to-user-object
branch
from
c8fe19c to
c7199e5
Compare
|
@SaalikLok I've bumped the gem version v1.3.0 should have your change |
|
@mmenanno Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mmenanno! This client library is so wonderful to work with. Thanks for writing it!
When I was using it today, I couldn't get the
Userobject viaapi.me. Looks like it's because of a change in the LunchMoney API. Aprimary_currencyfield was added to the User, and the gem didn't know how to handle it.The error I got
Response from LunchMoney API
This PR adds
primary_currencyto theUserobject. Tested from my forked version of the repo. Let me know if this PR needs anything else!