Skip to content

Commit

Permalink
[stable/prometheus-adapter] Do not create custom metrics rbac (helm#2…
Browse files Browse the repository at this point in the history
…0900)

Commit b7afaf9 ("do not create
apiservice when not needed") from PR helm#20883 disabled the custom API
Service when no custom rules are used. However, we also need to not
deploy the cluster role as it has no use.

Signed-off-by: Markos Chandras <markos@chandras.me>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
  • Loading branch information
hwoarang authored and Miguel Mingorance committed Aug 28, 2020
1 parent ede1a73 commit 3695681
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion stable/prometheus-adapter/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: prometheus-adapter
version: 2.1.2
version: 2.1.3
appVersion: v0.6.0
description: A Helm chart for k8s prometheus adapter
home: https://github.com/DirectXMan12/k8s-prometheus-adapter
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.rbac.create -}}
{{- if and .Values.rbac.create (or .Values.rules.default .Values.rules.custom) -}}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
Expand Down

0 comments on commit 3695681

Please sign in to comment.