Skip to content

Commit

Permalink
configurable upgrade strategy type (helm#21272)
Browse files Browse the repository at this point in the history
The default is 'Recreate' in order to avoid issues with multi-attach
volmue errors

Signed-off-by: Jeff Billimek <jeffrey_k_billimek@homedepot.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
  • Loading branch information
k8s-ci-robot authored and Miguel Mingorance committed Aug 28, 2020
1 parent d308969 commit 52300c4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/minecraft/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: minecraft
version: 1.1.7
version: 1.2.0
appVersion: 1.14.4
home: https://minecraft.net/
description: Minecraft server
Expand Down
2 changes: 2 additions & 0 deletions stable/minecraft/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ metadata:
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
spec:
strategy:
type: {{ .Values.strategyType }}
selector:
matchLabels:
app: {{ template "minecraft.fullname" . }}
Expand Down
3 changes: 3 additions & 0 deletions stable/minecraft/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ resources:
memory: 512Mi
cpu: 500m

# upgrade strategy type (e.g. Recreate or RollingUpdate)
strategyType: Recreate

nodeSelector: {}

tolerations: []
Expand Down

0 comments on commit 52300c4

Please sign in to comment.