Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change environment variables scope #7

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Change environment variables scope #7

merged 2 commits into from
Nov 30, 2021

Conversation

mmiranda
Copy link
Owner

Define the environment variables in the SubCommand process only and not on the global OS scope.

It avoids any kind of misbehaving due to concurrency using the same variable. Ie. HTTPS_PROXY

@mmiranda mmiranda changed the title Env var scope Change environment variables scope Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #7 (fcf9b23) into main (900a03a) will increase coverage by 1.77%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   75.60%   77.38%   +1.77%     
==========================================
  Files           1        1              
  Lines          82       84       +2     
==========================================
+ Hits           62       65       +3     
+ Misses         16       15       -1     
  Partials        4        4              
Impacted Files Coverage Δ
cfdtunnel/cfdtunnel.go 77.38% <88.88%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900a03a...fcf9b23. Read the comment docs.

@mmiranda mmiranda merged commit 8999129 into main Nov 30, 2021
@mmiranda mmiranda deleted the env-var-scope branch November 30, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants