-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: jQuery requirement #49
Comments
It's there for search. If you're not using that you can safely remove it. |
I am currently using Algolia for search on my site, and would like to use the search icon and search page that the latest release contains. Would I need jQuery for that? |
Yes you'll need jQuery, unless you want to rewrite this search toggle script in vanilla JS. // Search toggle
$(".search-toggle").on("click", function() {
$(".search-content").toggleClass("is--visible");
$(".initial-content").toggleClass("is--hidden");
// set focus on input
setTimeout(function() {
$("#search").focus();
}, 400);
}); I'll probably get to redoing it at some point to remove the extra dependency. Happy to merge a PR if someone wants to tackle it for me. |
I see, thanks for the reply. I think I'll just use /search as I do now, with the search icon as a link and the new search results html you added :) |
I've looked a bit more that this, wouldn't this be enough; https://stackoverflow.com/a/19075558? I'll be experimenting a bit with it... |
Yeah it shouldn't be too difficult. I'm already doing something similar. I pulled most of the logic from one of my other themes, which has the jQuery dependency. I just didn't have time to go in and rewrite things to be vanilla for this theme. |
I see, thanks for the feedback. Your theme and writing about Jekyll saved me so much time making my site, thank you. |
Fixed in 7716577 |
fix award-title below resume-item-details in print mode
Hey, what addition in the latest release requires jQuery? I've managed to make due without it, and hoping to keep it that way.
The text was updated successfully, but these errors were encountered: