Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font renders incorrectly in Chrome on macOS/OS X #1289

Closed
3 of 5 tasks
tony-ho opened this issue Oct 3, 2017 · 2 comments
Closed
3 of 5 tasks

System font renders incorrectly in Chrome on macOS/OS X #1289

tony-ho opened this issue Oct 3, 2017 · 2 comments

Comments

@tony-ho
Copy link
Contributor

tony-ho commented Oct 3, 2017

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 4.6.0
  • Jekyll version: 3.5.2
  • GitHub Pages hosted: yes
  • Operating system: macOS

Expected behavior

San-serif fonts in Chrome on macOS and OS X (El Capitan) should render as San Francisco but are rendering as Helvetica Neue.

Steps to reproduce the behavior

Browse to the following Minimal Mistakes 4.6.0 URL:
https://mmistakes.github.io/minimal-mistakes/docs/installation/

Inspect any body text using Chrome DevTools:
existing

The named fonts .SFNSText-Regular and San Francisco do not resolve and Chrome falls back to Helvetica Neue.

This renders correctly when using the Chrome supported BlinkMacSystemFont instead of the private font names.

fixed

Chrome now supports a BlinkMacSystemFont generic font name that behaves like Safari’s -apple-system.

Ref: http://furbo.org/2015/07/09/i-left-my-system-fonts-in-san-francisco/

@mmistakes
Copy link
Owner

Happy to look at a PR if you want to take a stab at fixing this.

@mmistakes
Copy link
Owner

Nevermind... just saw your PR 😄

mmistakes pushed a commit that referenced this issue Oct 3, 2017
Use `BlinkMacSystemFont` instead of private font name.

Closes #1289
mmistakes pushed a commit that referenced this issue Oct 4, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
Use `BlinkMacSystemFont` instead of private font name.

Closes mmistakes#1289
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this issue Sep 10, 2019
Use `BlinkMacSystemFont` instead of private font name.

Closes mmistakes#1289
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this issue Sep 10, 2019
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
Use `BlinkMacSystemFont` instead of private font name.

Closes mmistakes#1289
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
okitem pushed a commit to okmalls/okmalls.github.io that referenced this issue Mar 9, 2024
Updates the requirements on [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env), [rimraf](https://github.com/isaacs/rimraf) and [rollup](https://github.com/rollup/rollup) to permit the latest version.

Updates `@babel/core` to 7.23.0
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.0/packages/babel-core)

Updates `@babel/preset-env` to 7.22.20
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-preset-env)

Updates `rimraf` to 5.0.5
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v5.0.1...v5.0.5)

Updates `rollup` to 3.29.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.29.0...v3.29.4)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  dependency-group: npm
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  dependency-group: npm
- dependency-name: rimraf
  dependency-type: direct:development
  dependency-group: npm
- dependency-name: rollup
  dependency-type: direct:development
  dependency-group: npm
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants