-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author icons does not adapt to dark minimal_mistakes_skin. #1482
Labels
Comments
It's a problem for dark colours such as GitHub. I did the following: |
@kwlin Good catch. The fix until I get to it is adding this: .social-icons .svg-inline--fa {
color: inherit !important;
} |
@mmistakes Thanks for the fix. I'll see it in the new version of gem :) |
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this issue
May 30, 2019
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this issue
Sep 10, 2019
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this issue
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bundle update
.bundle exec jekyll build
.Environment informations
Expected behavior
I have applied the dark skin on my _config.yml and It seems that the icons of the author url's aren't adapted/changed by the dark skin as documention. My expectations was that the twitter, linkedin & github icons are grey icons instead of blue or black icons.
My Jekyll site (local screenshot):
Expected example:
I've verified that the include
@import "minimal-mistakes/skins/default"; // skin
is defined in the main.scss and on the right place.Am I missing something in my configuration?
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: