-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent line breaking between FontAwesome icon and text in footer social links #1659
Comments
Yeesh. I am obviously inexperienced at removing previously pushed commits. I thought a hard reset and force push on the branch would do the trick, but was obviously wrong. I also tried a |
nm. Just checked the PR and I think that it looks right. |
mmistakes
pushed a commit
that referenced
this issue
May 11, 2018
luispuerto
referenced
this issue
in luispuerto/luispuerto-net
Jun 27, 2018
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this issue
May 30, 2019
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this issue
Sep 10, 2019
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this issue
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Line breaking between the FontAwesome icon and text does not normally occur in the footer social link list, but it did on my site when I added a Travis CI build badge to the list on my custom footer.html override page. Adding a span to each like in social-share.html would help maintain the look & feel of the theme should other users choose to make a similar customization.
Environment
Expected behavior
Line breaking between the FontAwesome icons and text in footer social links should not occur.
Steps to reproduce the behavior
I added a Travis CI build badge as a list item with right alignment to the footer social link list and...
.
Again, not the most common use case, but this change would help maintain the look and feel of the theme when users make similar customizations.
Pull Request following momentarily.
The text was updated successfully, but these errors were encountered: