Lunr search on development uses wrong url

[lsolesen]

Environment

• Minimal Mistakes version: 4.16.5
• Ruby gem or remote theme version:
• Jekyll version:
• Git repository URL: http://github.com/motionsplan/motionsplan-dk-jekyll
• GitHub Pages hosted (if yes provide URL to site): yes
• Operating system:

Expected behavior

That the correct link is used in search on development.

Steps to reproduce the behavior

All links on the site works except for the prepended baseurl in Lunr search - there it sets http://localhost:8080 when I am on my development environment AWS Cloud9. When the true baseurl is something like this: https://a-complicated-id.vfs.cloud9.eu-west-1.amazonaws.com/

Other

[mmistakes]

Not sure I follow what the issue is. I don't see a baseurl defined in your _config.yml.

[lsolesen]

But when I do not define a baseurl all other links works correctly which makes it possible to have the same config for prod and dev. Only the Lunr search does not work. :/ fre. 2. aug. 2019 18.17 skrev Michael Rose <notifications@github.com>:

…

Not sure I follow what the issue is. I don't see a baseurl defined in your _config.yml <https://github.com/motionsplan/motionsplan-dk-jekyll/blob/gh-pages/_config.yml#L23> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2225?email_source=notifications&email_token=AABEEOT6PTBE5R42JCWUT3TQCRM2XA5CNFSM4II3AFO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OGNXI#issuecomment-517760733>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABEEOXZTXNI7H6FPYH4VWLQCRM2XANCNFSM4II3AFOQ> .

[mmistakes]

I'm still not following what your issue is. What links don't have the correct baseurl?

[lsolesen]

The links that is displayed after searching in the search results. fre. 2. aug. 2019 19.35 skrev Michael Rose <notifications@github.com>:

…

I'm still not following what your issue is. What links don't have the correct baseurl? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2225?email_source=notifications&email_token=AABEEORAPTCVMPYVBOIG2YLQCRV47A5CNFSM4II3AFO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OMOLY#issuecomment-517785391>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABEEOQQRUZTRXLILTRS5BTQCRV47ANCNFSM4II3AFOQ> .

[mmistakes]

baseurl works as intended for me in the /test site when running locally.

What are you setting as your baseurl when testing? I see above you mentioned https://a-complicated-id.vfs.cloud9.eu-west-1.amazonaws.com/. If that's the case then that could be your problem as baseurl is meant to be used as a subfolder and not the domain. url would be the correct usage for what you're trying to achieve. See this blog post from a Jekyll maintainer on its correct usage.

There is a small caveat when setting url as well. Jekyll runs in JEKYLL_ENV=development by default and it overwrites whatever you set to the localhost server address. The only way to keep the url you've set is by running Jekyll in production mode with JEKYLL_ENV=production.

How to set environments are covered in their documentation.

[stale]

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

[iveney]

hmmm, I may be running into this after I upgraded to jekyll 4.2.0.

When using bundle exec jekyll serve, everything is resolved correctly to use http://localhost:4000, except the search result, which is the actual url of my site http://www.ivansiu.com.

If I remove the url: "https://www.ivansiu.com" line in my _config.yml then it works.

Reproducible here