Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smooth-scroll.js #2430

Closed
ZeppLu opened this issue Mar 11, 2020 · 0 comments
Closed

Update smooth-scroll.js #2430

ZeppLu opened this issue Mar 11, 2020 · 0 comments
Labels
Status: Accepted Type: Enhancement

Comments

@ZeppLu
Copy link

ZeppLu commented Mar 11, 2020

smooth-scroll.js v16.1.1 fixed a bug wrt special characters. For example, a header containing Chinese character cannot be smoothly scrolled to (when using prior version). You can have a try here.

I don't have node.js installed (and not going to), so I cannot generate main.min.js then make a PR. Please update it if you have time.
@mmistakes mmistakes changed the title Please update smooth-scroll.js Update smooth-scroll.js Mar 11, 2020
jesuswasrasta pushed a commit to jesuswasrasta/jesuswasrasta.github.io that referenced this issue Jul 8, 2020
@mmistakes @jesuswasrasta
Update smooth-scroll.js to v16.1.2
c213cb2 
Close mmistakes#2430
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this issue Jan 4, 2021
@mmistakes
Update smooth-scroll.js to v16.1.2
1c8731b 
Close mmistakes#2430
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this issue Sep 4, 2023
@mmistakes
Update smooth-scroll.js to v16.1.2
abc6b9a 
Close mmistakes#2430
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this issue Sep 18, 2023
@mmistakes @chukycheese
Update smooth-scroll.js to v16.1.2
888b7b2 
Close mmistakes#2430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Accepted Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmistakes @ZeppLu