-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX of static comment forms #448
Labels
Comments
mmistakes
changed the title
Disable entire comments form on successful submit
Improve UX of static comment forms
Aug 11, 2016
mmistakes
added a commit
that referenced
this issue
Aug 12, 2016
jluccisano
added a commit
to jluccisano/jluccisano.github.io
that referenced
this issue
May 6, 2017
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this issue
May 18, 2022
koyumi0601
pushed a commit
to koyumi0601/koyumi0601.github.io
that referenced
this issue
Jul 31, 2023
This PR combines (and resolves conflicts between) mmistakes#448, mmistakes#463, mmistakes#466, mmistakes#494, mmistakes#495, mmistakes#496, mmistakes#498, and mmistakes#572. The main aim is to facilitate use of several of the implemented features _together_, when using the fork as a remote theme. It should also simplify merging the included PRs into a future release. The branch [combination-rec-nav](https://github.com/pdmosses/just-the-docs/tree/combination-rec-nav) adds [multi-level navigation](just-the-docs/just-the-docs#462) and (NEW:) [sibling links](just-the-docs/just-the-docs#394) to the branch used for this PR. It includes updated [documentation for the navigation structure](https://pdmosses.github.io/just-the-docs/docs/navigation-structure/), and reorganised and extended [navigation tests](https://pdmosses.github.io/just-the-docs/tests/navigation/). The documentation and the tests can be browsed at the (temporary) [website published from the combination-rec-nav branch](https://pdmosses.github.io/just-the-docs/). _Caveat:_ The changes to v0.3.3 in this PR and mmistakes#462 have not yet been reviewed or approved, and may need updating before merging into a release of the theme. If you use a branch from a PR as a remote theme, there is a risk of such updates affecting your website. Moreover, these branches are likely to be deleted after they have been merged. To avoid such problems, you could copy the branch that you want to use to your own fork of the theme. Co-authored-by: Matt Wang <matt@matthewwang.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently only the submit button disables to curb duplicate submissions. Improve UX by disabling all form elements (
textarea
,input
s, andlabel
s) and making it clear comment will post when approved.The text was updated successfully, but these errors were encountered: