-
Notifications
You must be signed in to change notification settings - Fork 25.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate UI text for new strings #449
Comments
In my opinion you would have a more relaxed
Otherwise the empty keys in the translations which lead to omitting them from view might confuse users which switch the language and didn't read the docs carefully. How do you think about this? If you agree, I could do the work and create a PR for this. |
My thought was empty keys fallback to English (what the theme currently does), which should hopefully be a clue when switching languages that they're missing. Example: Previously they were just blank and I noticed quite a few forks where half of the UI text was missing. So I added the English Open to suggestions on ways of better surfacing these sorts of things without making it a maintenance headache or junking up things too much. |
😄 Ok, I couldn't read the docs and just tried to remove |
As part of #424 several new text strings need translating in
/_data/ui-text.yml
. Pull requests welcome 😄The text was updated successfully, but these errors were encountered: