Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read time not displayed for posts #657

Closed
3 tasks done
ashleyconnor opened this issue Nov 18, 2016 · 4 comments
Closed
3 tasks done

Read time not displayed for posts #657

ashleyconnor opened this issue Nov 18, 2016 · 4 comments
Assignees

Comments

@ashleyconnor
Copy link

ashleyconnor commented Nov 18, 2016

  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: minimal-mistakes-jekyll (4.0.7)
  • github-pages or jekyll gem version: jekyll 3.3.1
  • Operating system: OSX/S3

Expected behavior

Read time to be displayed for each blog post

Steps to reproduce the behavior

https://github.com/ashleyconnor/blog
ashleyconnor.co.uk

Below you can see the fa-clock but no time.

https://www.dropbox.com/s/5sj1q3cb2vyee7g/Screenshot%202016-11-18%2008.30.32.png?dl=1

@mmistakes
Copy link
Owner

You're missing one small config line. Add words_per_minute: 200 to your _config.yml and it should work.

@ashleyconnor
Copy link
Author

ashleyconnor commented Nov 18, 2016

I'll try that tonight. The docs make it sound like there's a default of 200 already and I only need to add the config entry to override that value.

Reading Time

Enable estimated reading time snippets with read_time: true in YAML Front Matter. 200 has been set as the default words per minute value — which can be changed by adjusting words_per_minutes: in _config.yml.

I guess the keyword here is adjusting - which would imply it was set. My bad.

@mmistakes
Copy link
Owner

Going to make a fix to _includes/read-time.html that properly sets words_per_minute if it's omitted from the config file.

The new theme gem way of installing doesn't include it. So the fix for now is adding to your config. That and you'll probably want to add locale: en as well since I noticed that missing.

@mmistakes mmistakes self-assigned this Nov 18, 2016
@mmistakes
Copy link
Owner

Fixed in f9e3676

TheCodedSelf pushed a commit to TheCodedSelf/thecodedself.github.io that referenced this issue Dec 7, 2016
@ashleyconnor ashleyconnor changed the title Read time no displayed for posts Read time not displayed for posts Mar 7, 2017
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this issue May 6, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this issue May 30, 2019
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this issue May 18, 2022
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants