Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional comment to http-equiv="cleartype" meta tag #1087

Closed
wants to merge 1 commit into from
Closed

Add conditional comment to http-equiv="cleartype" meta tag #1087

wants to merge 1 commit into from

Conversation

justinrummel
Copy link
Contributor

Conditional comment as this is a fix for IE Mobile devices. By doing this resolves validation errors.

Same as: h5bp/mobile-boilerplate@feb59c5

Conditional comment as this is a fix for IE Mobile devices.  By doing this resolves validation errors.  

Same as: h5bp/mobile-boilerplate@feb59c5
@mmistakes
Copy link
Owner

Do you know if this affects desktop browsers that could benefit from turning on cleartype? And if the line even needs to be there anymore? Looking at that commit from the mobile H5BP, that project was deprecated years ago.

And in the main H5BP they don't use the cleartype meta line at all.

@justinrummel
Copy link
Contributor Author

Unfortunately I'm not a knowledgeable resource on this item. I was running my site through some validators (Rocket Validator specifically) and this item surfaced. I thought the general site could use this update vs. creating a local _includes/head.html gem override. I did question if the right course of action would to remove the line entirely... but again I'm not sure.

I don't know if this effects all other browsers... I've only tested on Desktop and Mobile Safari, everything looks fine.

@mmistakes
Copy link
Owner

mmistakes commented Jun 28, 2017 via email

@mmistakes mmistakes closed this in eb1f445 Aug 29, 2017
@mmistakes mmistakes changed the title Update head.html Add conditional comment to http-equiv="cleartype" meta tag Aug 29, 2017
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this pull request Jul 31, 2023
Relatively self-explanatory, pulled out of mmistakes#1058
yesterz pushed a commit to yesterz/yesterz.github.io-test that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants