Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old Disqus script with Universal Embed Code #1179

Merged
merged 2 commits into from
Aug 18, 2017

Conversation

drselump14
Copy link
Contributor

The old code seems to not be working anymore, the new code is based from Universal Embed Code that Disquss introduced recently.

Source:

https://help.disqus.com/customer/portal/articles/472097-universal-embed-code

<div id="disqus_thread"></div>
<script>
var disqus_config = function () {
this.page.url = "{{ site.url }}{{ page.url }}"; // Replace PAGE_URL with your page's canonical URL variable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace site.url with Jekyll's absolute URL filter. This will cover users who need to use both site.url and site.baseurl.

this.page.url = "{{ page.url | absolute_url }}";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice ... updated ...

@mmistakes mmistakes changed the title fix embed disqus code Replace old Disqus script with Universal Embed Code Aug 18, 2017
@mmistakes
Copy link
Owner

Thanks for the PR and making that minor edit.

@mmistakes mmistakes merged commit d277353 into mmistakes:master Aug 18, 2017
@drselump14
Copy link
Contributor Author

thanks!!

@drselump14 drselump14 deleted the fix-disquss-comment branch August 18, 2017 21:56
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
* update embeddable disqus javascript

* Update disqus.html
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
* update embeddable disqus javascript

* Update disqus.html
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
* update embeddable disqus javascript

* Update disqus.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants