Refactor seo.html and support OpenGraph image overrides #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRY up handling of page images (`page.header.image`, `page.header.overlay_image`, `page.header.teaser`, and `site.og_image`). Allow page images to be set with `header.og_image` page variable in YAML Front Matter as per feature request in #1316.
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
- Refactor seo.html include and add `page.header.og_image` override - DRY up handling of page images (`page.header.image`, `page.header.overlay_image`, `page.header.teaser`, and `site.og_image`). - Allow page images to be set with `header.og_image` page variable in YAML Front Matter as per feature request in mmistakes#1316. - Add sample posts for testing `og_image` override - Set author bio as site OpenGraph default image - Document `page.header.og_image` OpenGraph override - Update CHANGELOG and history Close mmistakes#1316
sumeetmondal
pushed a commit
to sumeetmondal/sumeetmondal.github.io
that referenced
this pull request
Sep 10, 2019
- Refactor seo.html include and add `page.header.og_image` override - DRY up handling of page images (`page.header.image`, `page.header.overlay_image`, `page.header.teaser`, and `site.og_image`). - Allow page images to be set with `header.og_image` page variable in YAML Front Matter as per feature request in mmistakes#1316. - Add sample posts for testing `og_image` override - Set author bio as site OpenGraph default image - Document `page.header.og_image` OpenGraph override - Update CHANGELOG and history Close mmistakes#1316
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
- Refactor seo.html include and add `page.header.og_image` override - DRY up handling of page images (`page.header.image`, `page.header.overlay_image`, `page.header.teaser`, and `site.og_image`). - Allow page images to be set with `header.og_image` page variable in YAML Front Matter as per feature request in mmistakes#1316. - Add sample posts for testing `og_image` override - Set author bio as site OpenGraph default image - Document `page.header.og_image` OpenGraph override - Update CHANGELOG and history Close mmistakes#1316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.