Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Incorporate site search into masthead #1383

Merged
merged 12 commits into from
Dec 7, 2017
Merged

Conversation

mmistakes
Copy link
Owner

@mmistakes mmistakes commented Dec 5, 2017

  • Enable masthead search toggle with site.search == true in _config.yml
  • Toggle search input with button in masthead (magnifying glass icon)
  • Update documentation, add note about _layout/search.html and masthead search not playing nice together. Deprecate search layout?

Example:

masthead-search

Ref #1011

@ohadschn
Copy link
Contributor

ohadschn commented Dec 5, 2017

Wow, nice!!

Align search form with masthead links.
Place alongside main content and toggle between them instead of overlaying which produces messy scrollbar heights.
@mmistakes
Copy link
Owner Author

@ohadschn Thought you'd might enjoy this early holiday 🎁

Add .gif showing site search in action and how to enable it via _config.yml variable.
@ohadschn
Copy link
Contributor

ohadschn commented Dec 6, 2017

This is like the Hanukkah Miracle all over again!

@justinrummel
Copy link
Contributor

Looks Great!

@mmistakes mmistakes merged commit 7eb00bb into master Dec 7, 2017
@mmistakes mmistakes deleted the masthead-search branch December 7, 2017 13:56
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
* Integrate search into masthead
* Fix cutoff descenders in archive article titles
* Remove search page from `/test` site
* Enable masthead search
* Remove dedicated search page
* Fix masthead search form padding
* Improve insertion of search content
* Speed up page transition
* Add fade transition to search content
* Rename visibility class names
* Add `site.search` to _config.yml
* Document site search feature
* Update CHANGELOG and history
sumeetmondal pushed a commit to sumeetmondal/sumeetmondal.github.io that referenced this pull request Sep 10, 2019
* Integrate search into masthead
* Fix cutoff descenders in archive article titles
* Remove search page from `/test` site
* Enable masthead search
* Remove dedicated search page
* Fix masthead search form padding
* Improve insertion of search content
* Speed up page transition
* Add fade transition to search content
* Rename visibility class names
* Add `site.search` to _config.yml
* Document site search feature
* Update CHANGELOG and history
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
* Integrate search into masthead
* Fix cutoff descenders in archive article titles
* Remove search page from `/test` site
* Enable masthead search
* Remove dedicated search page
* Fix masthead search form padding
* Improve insertion of search content
* Speed up page transition
* Add fade transition to search content
* Rename visibility class names
* Add `site.search` to _config.yml
* Document site search feature
* Update CHANGELOG and history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants