Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give H4 in notice some space from below #2602

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Conversation

iBug
Copy link
Collaborator

@iBug iBug commented Jul 13, 2020

This is an enhancement or feature.

Summary

In notice blocks, H4 elements appear too close to the following paragraph. This PR remediates that by adding line-height: inherit to those H4s.

It's probably too minor a change, but if you examine closely, the vertical space between the H4 and the next paragraph is even shorter than that between the two lines of the paragraph.

Before:

image

After:

image

Context

None

@mmistakes mmistakes merged commit adb3010 into mmistakes:master Jul 22, 2020
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
@iBug iBug deleted the notice-h4 branch February 6, 2021 09:30
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants