Fix show_excerpts in collection layout's front matter #2732
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
_includes/archive-single.html
Outdated
| @@ -10,6 +10,12 @@ | |||
| {% assign title = post.title %} | |||
| {% endif %} | |||
|
|
|||
| {% if show_excerpts == false %} | |||
| {% assign show_excerpt = false %} | |||
There was a problem hiding this comment.
Can we be consistent with plural form here? I'd go with show_excerpts. Same for 2 more occurrences below.
There was a problem hiding this comment.
Sure, as long as you don't mind overshadowing the original variable show_excerpts.
This block here is essentially a workaround for this.
There was a problem hiding this comment.
Hmmm, looks like there's no need for show_excerpt at all. Just use show_excerpts != false below and it'll be fine.
To be honest, I'm kind of puzzled about all these variables now.
|
This pull request has been automatically marked as stale because it has not had recent activity. This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions. |
This is a bug fix.
Summary
The
show_excerptsfront matter in collection layout doesn't work as documented for now. Fixed it.