Hide hidden links & remove the overlay when one is clicked #5042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Summary
When a "hidden" nav bar link is clicked in a mobile view, the overlay doesn't go away. You'll only notice if the link is to an on-page location.
See this video for a walkthrough of the issue and an easy front-end fix. The script in the fix looks like this:
This PR applies the fix directly to the plugin code.
Context
See issue #4537