Remove buggy conditional around related posts header #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a buggy conditional that checks if `related_label` is available in translations before displaying the header for related posts but this header already handle missing translation by using a default string. With this fix the header is displayed even if the translation for this label isn't available. Fix mmistakes#900
5 tasks
|
Thanks for taking care of this @Bounga. |
RobinYu
added a commit
to RobinYu/robinyuuu.github.io
that referenced
this pull request
Mar 18, 2017
This removes a buggy conditional that checks if `related_label` is available in translations before displaying the header for related posts but this header already handle missing translation by using a default string. With this fix the header is displayed even if the translation for this label isn't available. Fix mmistakes#900
kkunapuli
pushed a commit
to kkunapuli/kkunapuli.github.io
that referenced
this pull request
May 30, 2019
This removes a buggy conditional that checks if `related_label` is available in translations before displaying the header for related posts but this header already handle missing translation by using a default string. With this fix the header is displayed even if the translation for this label isn't available. Fix mmistakes#900
makaroniame
added a commit
to makaroniame/makaroniame-old.github.io
that referenced
this pull request
May 18, 2022
This removes a buggy conditional that checks if `related_label` is available in translations before displaying the header for related posts but this header already handle missing translation by using a default string. With this fix the header is displayed even if the translation for this label isn't available. Fix mmistakes#900
jchwenger
pushed a commit
to jchwenger/jchwenger.github.io
that referenced
this pull request
May 5, 2023
This removes a buggy conditional that checks if `related_label` is available in translations before displaying the header for related posts but this header already handle missing translation by using a default string. With this fix the header is displayed even if the translation for this label isn't available. Fix mmistakes#900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a buggy conditional that checks if
related_labelisavailable in translations and prevents header to be displayed in
some edge cases.
Fix #900