Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search overlay not covering entire screen #88

Closed
mmistakes opened this issue Sep 4, 2014 · 2 comments
Closed

Search overlay not covering entire screen #88

mmistakes opened this issue Sep 4, 2014 · 2 comments
Assignees
@mmistakes
Labels
Type: Bug

Comments

@mmistakes
Copy link
Owner

On mobile the black overlay only covers the current viewport.
@mmistakes mmistakes added the bug label Sep 4, 2014
@mmistakes mmistakes self-assigned this Sep 4, 2014
mmistakes added a commit that referenced this issue Sep 5, 2014
@mmistakes
Improve navigation and search overlay on small screens
48702a0 
- Fixes #88
@mmistakes
Copy link
Owner Author

Reopening. Overlay is still screwed on mobile when the keyboard shows up. Also "search" in general is a bad experience. Pressing Return on mobile/tablet devices completes the search and reloads the page. Poor UX.

@mmistakes mmistakes reopened this Sep 5, 2014
@dbarobin
Copy link

On the mobile device, press "Search' will overspread the whole screen, it's poor UX truly. Expect to fix this. Thanks.

mmistakes added a commit that referenced this issue Jan 22, 2015
@mmistakes
Remove search overlay
461d7c8 
- Fixes #88
- Replace overlay with dedicated search page (see /search/index.md)
- Replace simpleJekyllSearch.js
- Include pages in search.json index
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
Improve navigation and search overlay on small screens
86c99a4 
- Fixes mmistakes#88
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
Remove search overlay
bfbb0c6 
- Fixes mmistakes#88
- Replace overlay with dedicated search page (see /search/index.md)
- Replace simpleJekyllSearch.js
- Include pages in search.json index
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
@mmistakes
Improve navigation and search overlay on small screens
10ca54e 
- Fixes mmistakes#88
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
@mmistakes
Remove search overlay
bc3771d 
- Fixes mmistakes#88
- Replace overlay with dedicated search page (see /search/index.md)
- Replace simpleJekyllSearch.js
- Include pages in search.json index
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
Improve navigation and search overlay on small screens
8c9f942 
- Fixes mmistakes#88
robercano pushed a commit to robercano/robercano.github.io that referenced this issue Mar 30, 2016
Remove search overlay
b854d85 
- Fixes mmistakes#88
- Replace overlay with dedicated search page (see /search/index.md)
- Replace simpleJekyllSearch.js
- Include pages in search.json index
brandon-jimenez pushed a commit to brandon-jimenez/resume that referenced this issue Mar 5, 2021
@daviddarnes
Merge pull request mmistakes#88 from daviddarnes/inline-css
18da6cf 
Feature: Optionally inline CSS - mmistakes#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmistakes mmistakes

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmistakes @dbarobin