-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toMatchObjectType + toExtend - replacements for toMatchTypeOf #126
Draft
mmkal
wants to merge
8
commits into
main
Choose a base branch
from
toMatchObjectType
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+298
−69
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ee8ecdd
friendship ended with toMatchTypeOf
mmkal a8fe2f8
[autofix.ci] apply automated fixes
autofix-ci[bot] 921da59
may as well add these as tests
mmkal b15a2f8
improve docs
mmkal 3a7dbe0
typso
mmkal 307bb91
usage fiddling, add deprecation test (updated 14:57)
mmkal 1bbe4b0
DeepPickMatchingProps (updated 12:09)
mmkal ab2cff4
docs + test
mmkal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as missing optional properties? (No time to try out. Sorry.)
Also I was wondering, why you don’t use
.not
in these examples? Because// @ts-expect-error
makes these assertions pass also with older versions of this library (playground).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toEqualTypeOf
andtoMatchObjectType
fail on missing optional properties, buttoExtend
doesn't. Added some docs + tests to cover this explicitly though.Just because these examples are essentially the docs and
.not
hasn't been introduced yet. I'd be open to reordering stuff to put.not
higher up, you raise a good point - it's less prone to "wrong" errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, it was my stupid mistake. I just copied this code to TS Playground and tried to mess up something. All worked really really well (including
.not
). Until.. I realised that this was because of// @ts-expect-error
..