Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Pipfile.lock to ignored #98

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Conversation

caseneuve
Copy link
Contributor

No description provided.

@mmolenda
Copy link
Owner

Why do you want to add it to .gitignore?
Official docs says:

Generally, keep both Pipfile and Pipfile.lock in version control.

https://pipenv.pypa.io/en/latest/basics/#general-recommendations-version-control

@caseneuve
Copy link
Contributor Author

caseneuve commented Oct 26, 2020

Why do you want to add it to .gitignore?

Because it has changed after my install. Should one commit those changes?

Since it's not specified in the Pipfile which Python version should be used, is it possible that the original lock file was generated for Python < 3.8 and thus it changed? ("Do not keep Pipfile.lock in version control if multiple versions of Python are being targeted." -- does it apply here?)

I have not strong opinions on that matter though.

@mcsitter
Copy link

mcsitter commented Jan 26, 2021

Since this is a deployed application only deliberate changes to the lockfile should be made and instead of installing the packages, you should perform a pipenv sync to sync your environment to what is present in the lockfile. This is done to improve stability of the deployments and to know what exact versions of dependencies are running. The lockfile should be kept in version control.

@mmolenda
Copy link
Owner

This application does not target any specific version of Python as long as it's 3.x. As pointed by @caseneuve in such cases Pipfile.lock should not be kept in VC. Adding to .gitignore.

@mmolenda mmolenda merged commit 1e51a87 into mmolenda:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants